2012.12.12. 8:36 keltezéssel, Stanislaw Gruszka írta: > Hi > > I have one additional question: > > On Tue, Dec 11, 2012 at 12:03:53PM +0200, Daniel Golle wrote: >> + if (rt2x00_is_soc(rt2x00dev) || >> + test_bit(REQUIRE_EEPROM_FILE, &rt2x00dev->cap_flags)) >> + rt2800pci_read_eeprom_file(rt2x00dev); > Is || correct here ? There are various embedded boards where a Ralink WiFi chip is soldered directly onto the PCB and that does not have a separate EEPROM. The EEPROM data is stored in the main flash of the board. The '||' allows to load the EEPROM data via firmware API for such PCI devices as well. However, the condition can be simplified. The REQUIRE_EEPROM_FILE bit is always set for SoC devices, so the 'rt2x00_is_soc(rt2x00dev) ||' part is superfluous. Given the fact that the patch must be reworked, this part will go away anyway probably. -Gabor -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
