On Wednesday, December 12, 2012 07:08:06 PM Kalle Valo wrote: > Hi, > > On 12/12/2012 10:58 AM, Vladimir Kondratiev wrote: > > > Subject: [PATCH] wireless: fix Atheros drivers compilation > > > > Bug introduced in commit: > > wireless: allow Atheros card to not depend on ath.ko > > > > Change in CONFIG_ option name should be reflected in top level Makefile > > You should explain what the bug was (if ath6kl was the only enabled > atheros driver it wasn't included in the compilation). > > > Signed-off-by: Vladimir Kondratiev <qca_vkondrat@xxxxxxxxxxxxxxxx> > > Thanks, this fixed it. > > Tested-by: Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> > > John, as this bug is in wireless-next and is on it's way to 3.8, we > should get this fix also to 3.8. > > Kalle > OK, below same patch with explanation added. Good now? >From bb80d009b31c2b0751d156d6a653547107d490fa Mon Sep 17 00:00:00 2001 From: Vladimir Kondratiev <qca_vkondrat@xxxxxxxxxxxxxxxx> Date: Wed, 12 Dec 2012 10:56:09 +0200 Subject: [PATCH v2] wireless: fix Atheros drivers compilation Bug introduced in commit: wireless: allow Atheros card to not depend on ath.ko Commit in question changed CONFIG_ATH_COMMON to CONFIG_ATH_CARDS as "Atheros card" indication in drivers/net/wireless/ath/Kconfig but it is used also by drivers/net/wireless/Makefile If there are only Atheros cards that do not require ATH_COMMON, whole Makefile for Atheros cards was not executed; and as result, driver won't compile in this case. Change in CONFIG_ option name should be reflected in the drivers/net/wireless/Makefile Signed-off-by: Vladimir Kondratiev <qca_vkondrat@xxxxxxxxxxxxxxxx> --- drivers/net/wireless/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/Makefile b/drivers/net/wireless/Makefile index 062dfdf..2ba8cb8 100644 --- a/drivers/net/wireless/Makefile +++ b/drivers/net/wireless/Makefile @@ -47,7 +47,7 @@ obj-$(CONFIG_RT2X00) += rt2x00/ obj-$(CONFIG_P54_COMMON) += p54/ -obj-$(CONFIG_ATH_COMMON) += ath/ +obj-$(CONFIG_ATH_CARDS) += ath/ obj-$(CONFIG_MAC80211_HWSIM) += mac80211_hwsim.o -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
