From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> Date: Mon, 10 Dec 2012 10:41:06 +0100 > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > ip_check_defrag() might be called from af_packet within the > RX path where shared SKBs are used, so it must not modify > the input SKB before it has unshared it for defragmentation. > Use skb_copy_bits() to get the IP header and only pull in > everything later. > > The same is true for the other caller in macvlan as it is > called from dev->rx_handler which can also get a shared SKB. > > Reported-by: Eric Leblond <eric@xxxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx> > --- > For some versions of the kernel, this code goes into af_packet.c So the bug is that ip_check_defrag() has a precondition which is met properly by all callers except AF_PACKET. If this is the case, remind me why are we changing ip_check_defrag() rather than the violator of the precondition? -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
