Search Linux Wireless

Re: [PATCH] {nl, cfg, mac}80211: set beacon interval and DTIM period on mesh join

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/07/2012 12:25 PM, Thomas Pedersen wrote:
On Thu, Dec 6, 2012 at 2:50 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
On Wed, 2012-12-05 at 14:57 -0800, Thomas Pedersen wrote:
On Wed, Dec 5, 2012 at 2:06 PM, Marco Porsch
<marco.porsch@xxxxxxxxxxxxxxxxxxx> wrote:
Move the default mesh beacon interval and DTIM period to cfg80211 and
make it accessible to nl80211. This enables setting both values when joining
an MBSS.

NOTE: In a mesh with links in PS mode it is not advised to use the default
parameters 1000:4, as these cause excessive buffering delays that exceed
various timeouts (e.g. HWMP path request).

Then make the default parameters reasonable? How is 1000:2?

That's still ~2 seconds, no?

Yeah I guess those would both be unsuitable for PS anyway, so it's fine as is.

Snap, I just see carl9170 has a check for beacon interval and DTIM period [1].

I'll change the DTIM period default value.
To my best knowledge, it does not do any difference out of powersave mode, and for powersave DTIM period 1 is favourable. Any objections?

--Marco


[1]
/*
 * Therefore a hard limit for the broadcast traffic should
 * prevent false alarms.
 */
if (vif->type != NL80211_IFTYPE_STATION &&
    (bss_conf->beacon_int * bss_conf->dtim_period >=
     (CARL9170_QUEUE_STUCK_TIMEOUT / 2))) {
	err = -EINVAL;
	goto out;
}

(CARL9170_QUEUE_STUCK_TIMEOUT is 5500.)

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux