On 2012-12-07 6:53 AM, Rajkumar Manoharan wrote: > On Thu, Dec 06, 2012 at 11:35:33AM -0800, Adrian Chadd wrote: >> On 6 December 2012 09:40, Felix Fietkau <nbd@xxxxxxxxxxx> wrote: >> > This reverts commit f74b9d365ddd33a375802b064f96a5d0e99af7c0. >> > >> > Turns out reverting commit a240dc7b3c7463bd60cf0a9b2a90f52f78aae0fd >> > "ath9k_hw: Updated AR9003 tx gain table for 5GHz" was not enough to >> > bring the tx power back to normal levels on devices like the >> > Buffalo WZR-HP-G450H, this one needs to be reverted as well. >> > >> > This revert improves tx power by ~10 db on that device >> >> Did anyone figure out why this was happening? >> >> Maybe we should look at the HAL commits around the same time to see if >> someone changed the programming - eg, assuming TPC is always on, or >> the 2 stream / 3 stream reduction PHY register, or such. >> > Generally we update initval taken from Systems team. We might have missed to > program the some registers while updating initvals. I prefer to fix the missing > portion rather than reverting ini tables. Otherwise we end up with using > older initvals and hard to debug hw related issues. For a few months I was trying to get an answer from the Systems team as to why that change was made. Contacted several people about it, got no proper response. When I first found the bug (a long time ago), I did extensive review of internal changes to driver/initvals around that time, and I'm pretty confident that this tx power issue is not caused by missing changes that we forgot to port over. - Felix -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
