On 12/06/2012 07:32 AM, Joe Perches wrote: > This brcmf_err macro should probably be in dhd.h, > not in a debug header and not guarded by DEBUG at all. Not really. dhd.h is only used in common part of the driver. dhd_dbg.h is used in common and bus-specific part of the driver. It is arguable whether brcmf_err() or logging in general is a debugging feature, but I do not want to go there. Gr. AvS -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html