On Fri, 2012-12-07 at 09:47 +0530, Vasanthakumar Thiagarajan wrote: > struct mac_address will be used by ACL related configuration ops. I'd prefer that any new code _not_ use struct mac_address but use u8 addr[ETH_ALEN] instead. That's the most common style in the kernel. $ git grep -E "\bu8\s+\w+\s*\[\s*ETH_ALEN\s*\]" | wc -l 749 $ git grep -E "\bstruct\s+mac_address\b" | wc -l 13 There are also uses of char and unsigned char $ git grep -E "\bchar\s+\w+\s*\[\s*ETH_ALEN\s*\]" | wc -l 121 Some of those are ancient, but it'd be good to be consistent throughout the kernel. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html