On Thu, Dec 6, 2012 at 8:47 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > As the dummy_rule (also renamed from irule) is only > used for output by the reg_rules_intersect() function > there's no need to clear it at all, remove that. > > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx> Acked-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxxxxxxxx> The removal of the pointer is fine but the removal of the memset() is not trivial but given that reg_rules_intersect() does indeed re-set all elements of the struct this works OK. If reg_rules_intersect() ever branches though we may need to re-add a memset() back, but its fine like this. The issue I was trying to avoid was if you do not memset you potentially piggy backed data set from the previous intersect and this could potentially reduce the number of possible valid rules. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
