On Thu, Dec 6, 2012 at 10:17 AM, Gabor Juhos <juhosg@xxxxxxxxxxx> wrote:
> @@ -416,19 +423,26 @@ static u32 ath9k_patch_initval(u32 idx, u32 val)
> return val;
> }
>
> -static void ath9k_hw_print_initval(const char *name, const u32 *array, u32 rows, u32 columns, bool onedim)
> +static void ath9k_hw_print_initval(const char *name, const u32 *array, u32 rows,
> + u32 columns, bool onedim, bool wide)
> {
> - u32 p_columns = columns > 5 ? 5 : columns;
> + u32 p_columns;
> u32 col, row;
>
> - /*
> - * This checksum stuff is designed for columns <= 8),
> - * and spreads the checksum over 64 bits but since currently
> - * the initval max column size is 6 we only use the first 48
> - * bits.
> - */
> - if (columns > 6)
> - return;
> + if (wide) {
> + p_columns = columns;
> + } else {
> + p_columns = columns > 5 ? 5 : columns;
> +
> + /*
> + * This checksum stuff is designed for columns <= 8),
> + * and spreads the checksum over 64 bits but since currently
> + * the initval max column size is 6 we only use the first 48
> + * bits.
> + */
> + if (columns > 6)
> + return;
> + }
The comment here was for the case that we were using the old nasty
checksum thingy I invented, prior to you adding SHA1 checksum support.
The column limitation therefore seems artificial here ?
Also, as per Adrian's advice on the eeprom dump tool, perhaps we can
remove clutter from the initvals tool by allowing us to copy to the
local directory the initval files from a linux-next tag.
git show next-20121204:drivers/net/wireless/ath/ath9k/ar9002_initvals.h
> path/ar9002_initvals.h
For example. But this would mean requiring us to get diffs by using a
kernel git tree, separate from where we are. Not sure if there are
gains with this strategy. Its unclear.
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
