Search Linux Wireless

Re: [PATCH] qca-swiss-army-knife: Add support to dump AR9003 chips EEPROM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Just a general comment - wouldn't it be cleaner to have the PCI IDs
and the EEPROM definitions pulled from the ath9k driver source or a
separate header file, so you don't run the risk of having definitions
"drift" slightly?

I doubt that anyone is going to change the cal data format or the
default templates very often (or at all!), but .. just having those
definitions duplicated feels wrong to me.

I have EEPROM dump/parse utilities in FreeBSD, but I pull the EEPROM
structure definitions out of the HAL code so I only have them defined
in one place.

2c,


Adrian
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux