Search Linux Wireless

Re: Warning emited by 2.6.24-rc6-git5

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> I don't think it is really broken.  The packet it self is aligned. I'm
> not sure who has to be responsible for payload alignment you may have
> 10 other protocols packed into it,  each with variable length
> unaligned header.

That doesn't actually happen though, or it becomes the responsibility of
the unwrapper to handle it. The only thing 802.11 really wraps into the
payload is the protocol, with possibly an 8-byte rfc1042 header (that
doesn't break 4-byte alignment). If there's something like VPN
encapsulated it obviously becomes the responsibility of the VPN code to
align the packet properly before passing it off to the IP stack. But
where we do have IP right in our packet we need to make sure we give it
properly aligned packets.

> I understand that  I'll see what can be done, yet I don't like it

Not sure what there is to like about. I know Intel and powerpc hardware
handles unaligned loads (though at a price), but I also know that there
will be somebody sticking cards into a sparc64 or arm machine where it
fails. Aligning the packets in firmware, before they're DMA'ed into
memory, is simply the cheapest option.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux