> > + * @power_dBm: requested transmit power > > + * @max_antenna_gain_dBi: maximum antenna gain > Mixed case is bad. changed. > > + * @IEEE80211_HW_2GHZ_SHORT_PREAMBLE_INCAPABLE: > > + * Hardware is not capable of receiving frames with short preamble on > > + * the 2.4 GHz band. > Let's add it when we actually find hardware that needs it. I disagree. It's literally two lines of code (one defining it and one using it) and makes things more easy to discover when writing a driver. > > + * @max_antenna_gain_dBi: maximum antenna gain in dBi > > + * @max_power_dBm: maximum transmission power > Again, no mixed case. changed too > > +extern int ieee80211_frequency_to_channel(int freqMhz); > Mixed case again. Do you really need to add units to these names? They should > just be all the same throughout the code. Ok, changed. > > + strcpy(name, "mac80211"); > > > > return 0; > > } > It's simple, sure, but no. Let's not change userspace facing behavior if we > can. If you really need to, use "IEEE 802.11". It's pretty dumb to indicate the mode that way, but I changed it to just "IEEE 802.11" now. Will repost later. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
