On Sunday 23 December 2007 17:15:08 Johannes Berg wrote:
> + * @power_dBm: requested transmit power
> + * @max_antenna_gain_dBi: maximum antenna gain
Mixed case is bad.
> + * @IEEE80211_HW_2GHZ_SHORT_PREAMBLE_INCAPABLE:
> + * Hardware is not capable of receiving frames with short preamble on
> + * the 2.4 GHz band.
Let's add it when we actually find hardware that needs it.
> + * @max_antenna_gain_dBi: maximum antenna gain in dBi
> + * @max_power_dBm: maximum transmission power
Again, no mixed case.
> @@ -136,4 +294,14 @@ extern void wiphy_unregister(struct wiph
> */
> extern void wiphy_free(struct wiphy *wiphy);
>
> +/**
> + * ieee80211_channel_to_frequency - convert channel number to frequency
> + */
> +extern int ieee80211_channel_to_frequency(int chan);
> +
> +/**
> + * ieee80211_frequency_to_channel - convert frequency to channel number
> + */
> +extern int ieee80211_frequency_to_channel(int freqMhz);
Mixed case again. Do you really need to add units to these names? They should
just be all the same throughout the code.
> everything/net/mac80211/ieee80211_i.h 2007-12-23 22:05:39.489081868 +0100
> @@ -79,9 +79,8 @@ struct ieee80211_sta_bss {
> u8 ssid[IEEE80211_MAX_SSID_LEN];
> size_t ssid_len;
> u16 capability; /* host byte order */
> - int hw_mode;
> - int channel;
> - int freq;
> + enum ieee80211_band band;
> + int freqMhz;
Ditto.
> --- everything.orig/net/mac80211/ieee80211_ioctl.c 2007-12-23
> 22:02:18.509098090 +0100 +++
> everything/net/mac80211/ieee80211_ioctl.c 2007-12-23 22:05:39.509081760
> +0100 @@ -129,22 +129,7 @@ static int ieee80211_ioctl_giwname(struc
> struct iw_request_info *info,
> char *name, char *extra)
> {
> - struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
> -
> - switch (local->hw.conf.phymode) {
> - case MODE_IEEE80211A:
> - strcpy(name, "IEEE 802.11a");
> - break;
> - case MODE_IEEE80211B:
> - strcpy(name, "IEEE 802.11b");
> - break;
> - case MODE_IEEE80211G:
> - strcpy(name, "IEEE 802.11g");
> - break;
> - default:
> - strcpy(name, "IEEE 802.11");
> - break;
> - }
> + strcpy(name, "mac80211");
>
> return 0;
> }
It's simple, sure, but no. Let's not change userspace facing behavior if we
can. If you really need to, use "IEEE 802.11".
Also.. do you really need to rename ieee80211_rate to ieee80211_bitrate? Seems
all the same to me and I would prefer a shorter name.
Thanks,
-Michael Wu
Attachment:
signature.asc
Description: This is a digitally signed message part.
