> A few minor comments, looks good otherwise.
>
> > status = WLAN_STATUS_REQUEST_DECLINED;
> >
> > +
>
> spurious newline added, I'd think.
will do
>
> > + /* prepare reordering buffer */
> > + tid_agg_rx->reorder_buf =
> > + kmalloc(buf_size * sizeof(struct sk_buf *), GFP_ATOMIC);
> > + if (!tid_agg_rx->reorder_buf) {
> > + printk(KERN_ERR "can not allocate reordering buffer "
> > + "to tid %d\n", tid);
>
> Should that be ratelimited just in case somebody is trying over and over
> again while we're under memory pressure?
>
done
> > + skb = dev_alloc_skb(sizeof(*mgmt) + local->hw.extra_tx_headroom + 1 +
> > + sizeof(mgmt->u.action.u.delba));
>
> What's "+ 1"?
that's for the category byte. in fact i think that the problem is not
here, but in a wrong allocation size in send_addba_resp that i will
fix.
>
> > + printk(KERN_DEBUG "rx BA session requested to stop on "
> > + "unactive tid %d\n", tid);
>
> typo: "inactive"
thanks
>
> > + sta = sta_info_get(local, temp_sta->addr);
> > +
> > + if (!sta)
> > + return;
>
> Still have that?
>
i have cleaned it now, thatnks.
> Thanks,
> johannes
>
>
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
