A few minor comments, looks good otherwise.
> status = WLAN_STATUS_REQUEST_DECLINED;
>
> +
spurious newline added, I'd think.
> + /* prepare reordering buffer */
> + tid_agg_rx->reorder_buf =
> + kmalloc(buf_size * sizeof(struct sk_buf *), GFP_ATOMIC);
> + if (!tid_agg_rx->reorder_buf) {
> + printk(KERN_ERR "can not allocate reordering buffer "
> + "to tid %d\n", tid);
Should that be ratelimited just in case somebody is trying over and over
again while we're under memory pressure?
> + skb = dev_alloc_skb(sizeof(*mgmt) + local->hw.extra_tx_headroom + 1 +
> + sizeof(mgmt->u.action.u.delba));
What's "+ 1"?
> + printk(KERN_DEBUG "rx BA session requested to stop on "
> + "unactive tid %d\n", tid);
typo: "inactive"
> + sta = sta_info_get(local, temp_sta->addr);
> +
> + if (!sta)
> + return;
Still have that?
Thanks,
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
