On Sun, 2007-12-16 at 23:17 +0100, Johannes Berg wrote: > > Eeek, yes, its the LED core's fault. > > dc47206e552c0850ad11f7e9a1fca0a3c92f5d65 is needed for various reasons > > but that means the patch below is also needed. Its been compile tested, > > once its runtime tested I'll push asap. > > Any reason you're using an rw semaphore rather than a simple mutex? > Nothing here is a hot-path, is it, and the led registrations are > mutually exclusive anyway, no? With a rw lock, the for loop of the trigger registration can happen in parallel with other trigger registrations. This case isn't a hot path as such but it keeps consistent style with other parts of the LED core where rw locks are used in hot paths. It could be replaced with a mutex instead though... Richard - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
