On Saturday 08 December 2007 07:35:21 Luis R. Rodriguez wrote: > Acked-by: Luis R. Rodriguez <mgrof@xxxxxxxxxxxxxxxxxx> > > Seems the patch may just need to be resent, not sure, but your mailer > may be messing with it. I'm using gmail --> show-original to retrieve > this as a patch so not sure if that would have messed the patch up (I > don't think so). But I get: > > mcgrof@nesi:~/devel/compat-wireless-2.6$ patch -p1 < > /home/mcgrof/patches/new-debug.diff > patching file drivers/net/wireless/ath5k/debug.c > patch: **** malformed patch at line 238: *modes) > > That hunk looks like this: > > @@ -96,9 +294,16 @@ void > ath5k_debug_finish_device(struct ath5k_softc *sc) > { > debugfs_remove(sc->debug.debugfs_debug); > + debugfs_remove(sc->debug.debugfs_registers); > + debugfs_remove(sc->debug.debugfs_tsf); > + debugfs_remove(sc->debug.debugfs_beacon); > + debugfs_remove(sc->debug.debugfs_reset); > debugfs_remove(sc->debug.debugfs_phydir); > } > > + > +/* functions used in other places */ > + > void > ath5k_debug_dump_modes(struct ath5k_softc *sc, struct ieee80211_hw_mode > *modes) > { > > > The last *modes line is the one it is complaining about. After moving > this line as: > > ath5k_debug_dump_modes(struct ath5k_softc *sc, struct ieee80211_hw_mode > *modes) thanks, luis. i will resend the patch with a few additions later. bruno - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html