On Dec 5, 2007 5:50 AM, bruno randolf <bruno@xxxxxxxxxxxxx> wrote:
> On Wednesday 05 December 2007 18:12:53 Jiri Slaby wrote:
> > > + char buf[5000];
> >
> > Doh, 4k stacks on i386! You can't do this safely.
>
> ohh! i didn't know.
>
> > I think we can use seq_* stuff here instead, see below.
>
> > Put those register in the array, and from .seq_next, return &array[++*pos]
> > or NULL for the last member. .seq_show will contain the REG_PRINT_APPEND
> > macro contents.
>
> thanks for the hint. i changed the patch to do that now. but unfortunately by
> doing so we loose the ability to print the register names.
>
> anyways, here is the new version:
>
>
> ath5k: add debugfs entries for registers, tsf, beacon
>
> 'registers' prints the value of some registers. this should be adapted to what
> we actually need later.
>
> 'tsf' prints the current HW TSF. writing "reset" into the file will reset the
> TSF.
>
> 'beacon' shows beacon relevant registers. writing "enable" into the file will
> enable beacons by writing AR5K_BEACON_ENABLE, "disable" will disable that bit.
>
> 'reset' performs a HW reset.
>
> Changes-licensed-under: GPL
> Signed-off-by: Bruno Randolf <bruno@xxxxxxxxxxxxx>
Acked-by: Luis R. Rodriguez <mgrof@xxxxxxxxxxxxxxxxxx>
Seems the patch may just need to be resent, not sure, but your mailer
may be messing with it. I'm using gmail --> show-original to retrieve
this as a patch so not sure if that would have messed the patch up (I
don't think so). But I get:
mcgrof@nesi:~/devel/compat-wireless-2.6$ patch -p1 <
/home/mcgrof/patches/new-debug.diff
patching file drivers/net/wireless/ath5k/debug.c
patch: **** malformed patch at line 238: *modes)
That hunk looks like this:
@@ -96,9 +294,16 @@ void
ath5k_debug_finish_device(struct ath5k_softc *sc)
{
debugfs_remove(sc->debug.debugfs_debug);
+ debugfs_remove(sc->debug.debugfs_registers);
+ debugfs_remove(sc->debug.debugfs_tsf);
+ debugfs_remove(sc->debug.debugfs_beacon);
+ debugfs_remove(sc->debug.debugfs_reset);
debugfs_remove(sc->debug.debugfs_phydir);
}
+
+/* functions used in other places */
+
void
ath5k_debug_dump_modes(struct ath5k_softc *sc, struct ieee80211_hw_mode
*modes)
{
The last *modes line is the one it is complaining about. After moving
this line as:
ath5k_debug_dump_modes(struct ath5k_softc *sc, struct ieee80211_hw_mode *modes)
it patches well. I can't test this as my laptops have all gone dead,
but it looks well, and compiles well.
Luis
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
