On Thu, 2007-11-29 at 09:34 +0800, Zhu Yi wrote: > The patch enables mac80211 to set interface MAC address after the > interface is UP. This is useful for wireless drivers load their firmware > in the mac80211 interface start() callback (called when interface UP). > Because for kernel built-in (vs. module) network drivers, they are > initialized in a very early stage (even before hard disk is ready). So > loading firmwares in the device pci_probe time is not a good idea. Some > devices for example iwlwifi cannot get MAC address without firmware being > loaded first. > > It also sets mac80211 dev->validate_addr to NULL so that we don't need to > have a MAC address in the dev->open time. This cannot possibly work We do a lot of MAC address sanity checking at _open() time *before* the place where you inserted the MAC address copy. Deferring MAC address setting to open() time is also *very* bad for the user experience because they no longer have the guarantee the the MAC address they see is the one that will be used when the interface is brought up. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
