ACK so i diff against current wireless-2.6 "everything" branch... I'll start asap then ;-) 2007/10/16, Luis R. Rodriguez <mcgrof@xxxxxxxxx>: > On 10/16/07, Nick Kossifidis <mickflemm@xxxxxxxxx> wrote: > > NACK we'll mess things up because we use hw also for mac80211_hw, too > > much use of "hw" is not recommended (also used in function names etc, > > it'll be difficult to track things down if we go too far). On the > > cleanups i did in madwifi-svn i used the name ath5k_hw for the struct, > > i think also "ah" or "ahw" or "board" or "card" etc are more > > appropriate for use as a variable name (on my cleanups i left it as > > "hal"). > > Agreed, perhaps "ah" is best as its used throughout the driver already. > > > Question: Since i don't know how things work, if i want to commit some > > patches should i wait for current patches to be commited on > > wireless-2.6 ? I have a patch series to commit about ath5k (my changes > > on madwifi-svn that weren't ported here) that include lots of cleanups > > and some hw.c updates. Against what code should i diff ??? Should i > > include current fixes along with mine (eg. Luis's fixes on base.c etc) > > ? > > Always diff against latest wireless-2.6.git. > > John already rebased wireless-2.6.git for the 2.6.23 change. In his > changes he already pulled most pending ath5k patch including my own so > I've pulled those changes onto ath5k svn and committed there. > > ath5k svn *should only* reflect what's on wireless-2.6.git except for > security fixes or compat changes (but I'll address this in another > e-mail soon). > > Luis > -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html