Search Linux Wireless

Re: [PATCH 1/6] ath5k: Ported new initval changes from OpenBSD to ath5k

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2007/10/8, Luis R. Rodriguez <mcgrof@xxxxxxxxx>:
> On Sun, Oct 07, 2007 at 02:49:23AM -0700, Nick Kossifidis wrote:
> > 2007/10/5, Luis R. Rodriguez <mcgrof@xxxxxxxxx>:
> > > Ported new initval changes from OpenBSD to ath5k to ar5212_ini[] and
> > > ar5212_ini_mode[].
> >
> > NACK
> >
> > Nothing new was introduced in OpenBSD cvs that i haven't already
> > included!, what have you ported ???
>
> Actually, you are right, an oversight by my part. Thanks for catching
> this. However after verying this I did find the one type. Please
> review.
>
> > > This also adds an O(log(N)) bitswap for one byte
> > > on ath5k_hw_bitswap(), thanks to Tom from OpenBSD.
> >
> > ACK it's used for modifying rf buffer settings...
>
> I think its easier to just new patches. I'll do so but please first
> review the small change below.
>
>   Luis
>
>
> diff --git a/drivers/net/wireless/ath5k/reg.h b/drivers/net/wireless/ath5k/reg.h
> index 1537517..f826422 100644
> --- a/drivers/net/wireless/ath5k/reg.h
> +++ b/drivers/net/wireless/ath5k/reg.h
> @@ -1980,4 +1980,4 @@ after DFS is enabled */
>  #define        AR5K_PHY_GAIN_2GHZ              0xa20c
>  #define        AR5K_PHY_GAIN_2GHZ_MARGIN_TXRX  0x00fc0000
>  #define        AR5K_PHY_GAIN_2GHZ_MARGIN_TXRX_S        18
> -#define        AR5K_PHY_GAIN_2GHZ_INI_5111     0x6480416c
> +#define        AR5K_PHY_GAIN_2GHZ_INI_5111     0x6448416a
>

I'll post a pach series asap here with my fixes against current
wireless-dev including your fixes on base.c/h and any other fixes
posted so far that are not included yet i hope now wireless-dev will
boot for me so i can also test them. About PHY_GAIN i did some tests
before ending up with this value, it comes from initialization of 5211
and after testing 5211+5111 and 5212+5111 combinations it seems it
performs better. The ideal solution would be to read antenna gain from
eeprom and somehow calculate this value dynamicaly instead of putting
a static one.

-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux