Search Linux Wireless

Re: [PATCH 1/6] ath5k: Ported new initval changes from OpenBSD to ath5k

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2007/10/5, Luis R. Rodriguez <mcgrof@xxxxxxxxx>:
> Ported new initval changes from OpenBSD to ath5k to ar5212_ini[] and
> ar5212_ini_mode[].

NACK

Nothing new was introduced in OpenBSD cvs that i haven't already
included!, what have you ported ???

Settings inside inivals.c are O.K. there is no need to change them and
if you do plz maintain the style, e.g. all BB TABLE settings go
together seperately per chipset (not as part of mac initialization)
etc. I've spent a lot time cleaning ini register settings up, plz
check out that these values you are adding are not already written in
a previous step.

> This also adds an O(log(N)) bitswap for one byte
> on ath5k_hw_bitswap(), thanks to Tom from OpenBSD.

ACK it's used for modifying rf buffer settings...

-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux