On Mon, 2007-09-24 at 13:24 -0400, Luis R. Rodriguez wrote: > * ath5k_hw_set_rfgain_opt() is defined once and used once, can we > instead make it inline? If we really are not going to re-use this > later why do we put it into a routine on its own? Why mark it inline then? The compiler will inline it anyway if it's only used once. And I haven't looked at the code but making it an own routine could possibly make the code more readable, especially if lots of indentation is involved.` johannes
Attachment:
signature.asc
Description: This is a digitally signed message part