On 9/24/07, Jiri Slaby <jirislaby@xxxxxxxxx> wrote: > From: Nick Kossifidis <mickflemm@xxxxxxxxx> > > ath5k, split hw into hw, phy and initvals > > Separate the hw code into logical pieces hw, phy and initvals for better > readability and maintainability. > > This include suggested file renames (_hw removal). > > Changes-licensed-under: ISC > Signed-off-by: Nick Kossifidis <mickflemm@xxxxxxxxx> > Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx> > Cc: Luis R. Rodriguez <mcgrof@xxxxxxxxx> <-- snip patch --> > [Message clipped] > http://mail.google.com/mail/?view=lg&msg=11536c180ed66ff1 I didn't want to take this approach before as it seemed we wanted to try to keep drivers without their own directory and consolidate drivers files into as many few files as necessary. Since it seems that has changed and it has been made clear that we *can* use a directory for each driver then I'd suggest we apply a similar patch but first move ath5k* to ath5k/. But anyway, I NACK this patch for the following reasons: * Copyright (c) 2007 The MadWiFi Team MadWifi is not a non-profit yet and as such it is advised to use individual copyright notices. * ath5k_hw_set_rfgain_opt() is defined once and used once, can we instead make it inline? If we really are not going to re-use this later why do we put it into a routine on its own? * #if 0's need to go, lets just remove this code instead. Luis - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
