On Thu, Aug 30, 2007 at 04:38:09AM +0300, Nick Kossifidis wrote: > 2007/8/28, Christoph Hellwig <hch@xxxxxxxxxxxxx>: > > Also this whole patch seems rather pointless. It saves only > > very little and turns the driver into a complete ifdef maze. > Also most > people will use 5212 code only, 5211 cards are on some old laptops and > 5210, well i couldn't even find a 5210 for actual testing :P FWIW, I'd bet dollars to donuts that distros will enable them all together. Is saving code space the only reason to turn these off? How much space do you save? Is there some way you can isolate and/or limit the number of ifdef blocks further? If so, we might consider a version of this patch that depends on EMBEDDED or somesuch...? John -- John W. Linville linville@xxxxxxxxxxxxx - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
