On Mon, 2007-08-27 at 19:45 -0400, Michael Wu wrote: > On Saturday 25 August 2007 03:37, Johannes Berg wrote: > > http://johannes.sipsolutions.net/patches/net-2.6.24/ > > > Patch 22: > + ap = sta_info_get(key->local, key->sdata->u.sta.bssid); > How does this work when we're setting a multicast/broadcast key on an AP > interface? Hmm. I don't think that ever worked correctly for when we ourselves are using WMM. I can fix that. > > + list_add(&key->list, &sdata->key_list); > Should we be holding the key mutex here? Yeah. > This patch does too many things. If you can split some things out into > separate patches, like moving code into key.c, it would be easier to review. Not easily since it's really intermingled with the ioctl code. Have you looked at the original? johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
