On Saturday 25 August 2007 03:37, Johannes Berg wrote: > http://johannes.sipsolutions.net/patches/net-2.6.24/ > Patch 22: + ap = sta_info_get(key->local, key->sdata->u.sta.bssid); How does this work when we're setting a multicast/broadcast key on an AP interface? + list_add(&key->list, &sdata->key_list); Should we be holding the key mutex here? This patch does too many things. If you can split some things out into separate patches, like moving code into key.c, it would be easier to review. Patch 23-29: ACK Thanks, -Michael Wu
Attachment:
pgpksNHj3D4JV.pgp
Description: PGP signature
