On Wed, 2007-08-15 at 13:54 +0200, ian wrote: > > le16_to_cpu(phy_flags_hw & RX_RES_PHY_FLAGS_ANTENNA_MSK) >> 4; > > > > looks totally bogus unless you somehow do macro magic to define the > > RX_RES_PHY...MASK in little endian... > > iwl-hw.h:#define RX_RES_PHY_FLAGS_ANTENNA_MSK __constant_cpu_to_le16(0xf0) > I don't understand how this would generate the warning though Ah, so there is macro magic. Why that, and not just convert the value to CPU first and then mask? i.e. #define RX_RES_PHY_FLAGS_ANTENNA_MSK 0xF0 and use (le16_to_cpu(phy_flags_hw) & RX_RES...MSK) >> 4 or something? > > Maybe it's time for you to get a cross compiler or better yet buy a > > big-endian machine and actually test things on that? :) > > > > No need for these drastic comments, for two warnings imho ;-) :) I'm spammed by warnings right now in my kernel build for some reason. I'm guessing gcc got a bit more trigger-happy or something. > I'm predicting that patch will arrive on linux-wireless soon too. > (took me quite some time to figure this out, because I was looking at the iwlwifi git) Alright :) johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
