Search Linux Wireless

warnings in iwlwifi

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  CC [M]  drivers/net/wireless/iwl-base-3945.o
drivers/net/wireless/iwl-base.c: In function ‘iwl_handle_data_packet_monitor’:
drivers/net/wireless/iwl-base.c:3318: warning: integer overflow in expression
drivers/net/wireless/iwl-base.c:3318: warning: integer overflow in expression
  CC [M]  drivers/net/wireless/iwl-3945.o
  CC [M]  drivers/net/wireless/iwl-3945-rs.o
  CC [M]  drivers/net/wireless/iwl-base-4965.o
drivers/net/wireless/iwl-base.c:2169: warning: large integer implicitly truncated to unsigned type
drivers/net/wireless/iwl-base.c:2170: warning: large integer implicitly truncated to unsigned type
drivers/net/wireless/iwl-base.c:2171: warning: large integer implicitly truncated to unsigned type
drivers/net/wireless/iwl-base.c:2172: warning: large integer implicitly truncated to unsigned type
drivers/net/wireless/iwl-base.c:2173: warning: large integer implicitly truncated to unsigned type
drivers/net/wireless/iwl-base.c:2179: warning: large integer implicitly truncated to unsigned type
drivers/net/wireless/iwl-base.c:2181: warning: large integer implicitly truncated to unsigned type
drivers/net/wireless/iwl-base.c:2183: warning: large integer implicitly truncated to unsigned type
drivers/net/wireless/iwl-base.c:2185: warning: large integer implicitly truncated to unsigned type
drivers/net/wireless/iwl-base.c:2186: warning: large integer implicitly truncated to unsigned type
drivers/net/wireless/iwl-base.c: In function ‘iwl_handle_data_packet_monitor’:
drivers/net/wireless/iwl-base.c:3318: warning: integer overflow in expression
drivers/net/wireless/iwl-base.c:3318: warning: integer overflow in expression


I suspect most of them are caused by endianness bugs.
This for example:

	le16_to_cpu(phy_flags_hw & RX_RES_PHY_FLAGS_ANTENNA_MSK) >> 4;

looks totally bogus unless you somehow do macro magic to define the
RX_RES_PHY...MASK in little endian...

Maybe it's time for you to get a cross compiler or better yet buy a
big-endian machine and actually test things on that? :)

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux