Search Linux Wireless

Re: [RFC] the recently discussed flags patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2007-08-14 at 18:48 +0200, Michael Buesch wrote:

> Please some more comments on what they actually mean
> and what's usually to do when the flag is set.

Will do.

> > +	/* Change filter flags, see above for FIF_* constants.
> > +	 *
> > +	 * Must be atomic due to running under the tx lock.
> > +	 * This callback is required.
> > +	 */
> > +	void (*change_filter_flags)(struct ieee80211_hw *hw,
> > +				    int changed_flags, int total_flags);
> 
> Better use unsigned int.

Yeah, did that.

> What does changed_flags and total_flags mean?
> I thought we'd like to have a pointer here, to the driver
> can clear what's not supported.

I changed that in the second version, and changed_flags indicates which
ones have changed since the last call so the driver need not set all of
them if that might be expensive.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux