On Tuesday 14 August 2007 18:21:55 Johannes Berg wrote: > +/* > + * flags for change_filter_flags() > + * > + * Note that e.g. if PROMISC_IN_BSS is unset then > + * you should still do MAC address filtering if > + * possible even if OTHER_BSS is set to indicate > + * no BSSID filtering should be done. > + */ > +#define FIF_PROMISC_IN_BSS 0x01 > +#define FIF_ALLMULTI 0x02 > +#define FIF_FCSFAIL 0x04 > +#define FIF_PLCPFAIL 0x08 > +#define FIF_CONTROL 0x10 > +#define FIF_OTHER_BSS 0x20 Please some more comments on what they actually mean and what's usually to do when the flag is set. > + /* Change filter flags, see above for FIF_* constants. > + * > + * Must be atomic due to running under the tx lock. > + * This callback is required. > + */ > + void (*change_filter_flags)(struct ieee80211_hw *hw, > + int changed_flags, int total_flags); Better use unsigned int. What does changed_flags and total_flags mean? I thought we'd like to have a pointer here, to the driver can clear what's not supported. -- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
