On Wednesday 27 June 2007 16:30:27 Johannes Berg wrote: > On Wed, 2007-06-27 at 15:08 +0200, Michael Buesch wrote: > > On Wednesday 27 June 2007 10:55:00 Johannes Berg wrote: > > > On Mon, 2007-06-25 at 16:28 +0200, Michael Buesch wrote: > > > > > > > case PRISM2_PARAM_PREAMBLE: > > > > - local->short_preamble = value; > > > > + if (value) > > > > + local_to_hw(local)->conf.flags |= IEEE80211_CONF_SHORT_PREAMBLE; > > > > + else > > > > + local_to_hw(local)->conf.flags &= ~IEEE80211_CONF_SHORT_PREAMBLE; > > > > + if (ieee80211_hw_config(local)) > > > > + ret = -EINVAL; > > > > > > any reason not to return the actual error code from hw_config here? Not > > > that it'll be any different from -EINVAL I expect... > > > > The reason is copy&paste from other PRISM2 IOCTLs ;) > > I'm OK with the real error code, too. > > I don't really care either way. > > > Though, the error code of hw_config is usually not useful _at all_. > > As it might not be the SHORT_PRMBL flag that produced it, but some of the > > other config settings. > > I would probably vote for any code in mac80211 to ignore that return value, > > except the places where a failure of hw_config would be fatal (init or > > places like that). > > Yeah, there's a todo item saying that we need a way to just commit the > changed settings. Well, sane drivers should basically already do that, as most information is saved redundantly in the driver's structs. Especially for operations that can fail. So it's basically a TODO for drivers, rather than mac80211. -- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
