On Wed, 2007-06-27 at 15:33 +0200, Michael Buesch wrote: > On Wednesday 27 June 2007 10:55:00 Johannes Berg wrote: > > On Mon, 2007-06-25 at 16:28 +0200, Michael Buesch wrote: > > > > > case PRISM2_PARAM_PREAMBLE: > > > - local->short_preamble = value; > > > + if (value) > > > + local_to_hw(local)->conf.flags |= IEEE80211_CONF_SHORT_PREAMBLE; > > > + else > > > + local_to_hw(local)->conf.flags &= ~IEEE80211_CONF_SHORT_PREAMBLE; > > > + if (ieee80211_hw_config(local)) > > > + ret = -EINVAL; > > > > any reason not to return the actual error code from hw_config here? Not > > that it'll be any different from -EINVAL I expect... > > > > johannes > > > > Another thing, while we are at it. > How is locking for the conf structure actually done? How is it > made impossible to read the value of "flags" in another thread, > while we update it in a non-atomic way, here? I don't see any locking, though we do have this code running under rtnl so you might need to check the other accesses. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
