Re: [PATCH] mac80211: Export short-preamble bit to drivers

[Johannes Berg <johannes@xxxxxxxxxxxxxxxx>]

On Mon, 2007-06-25 at 16:28 +0200, Michael Buesch wrote:

>  	case PRISM2_PARAM_PREAMBLE:
> -		local->short_preamble = value;
> +		if (value)
> +			local_to_hw(local)->conf.flags |= IEEE80211_CONF_SHORT_PREAMBLE;
> +		else
> +			local_to_hw(local)->conf.flags &= ~IEEE80211_CONF_SHORT_PREAMBLE;
> +		if (ieee80211_hw_config(local))
> +			ret = -EINVAL;

any reason not to return the actual error code from hw_config here? Not
that it'll be any different from -EINVAL I expect...

johannes

Attachment: signature.asc
Description: This is a digitally signed message part