Search Linux Wireless

Re: [PATCH] mac80211: Add module parameter for setting initial rate in rc80211_simple

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jiri Benc wrote:

Don't misuse module parameters, please. If you have more devices, this
single parameter will affect all of them. That's not a good approach,
especially when the value you are trying to change can be changed on
the fly.
--- snip ---
However, I'm not against setting the initial value to the lowest rate
available. As Johannes pointed out, if the rate control algorithm isn't
able to quickly migrate to higher rates, it's a good candidate for
rewrite.

I'm more than a little confused. First you tell me that setting the initial rate with a module parameter is bad because it sets a value for all _MY_ devices, then you say that you will allow a change that would affect _EVERYONE'S_ devices. Huh? I wrote the code the way I did because I thought it was much better to allow a local solution rather than a global one.

Larry

-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux