On Friday 01 June 2007 13:55:31 Olivier Cornu wrote: > 2007/6/1, Michael Buesch <mb@xxxxxxxxx>: > > This updates stop_queue(s) kdoc as currently there's > > a undocumented dependency. > > > > Stopping the queue from anywhere else than the ops->tx() > > callback will result in a hard to debug deadlock and > > system freeze (on UP). > > Sorry but: why would one call ieee80211_stop_queue() from outside of > the tx handler in the first place? Wouldn't that simply be a driver > design problem? No it wouldn't. A driver may want to stop (and probably flush) TX queues when it resets itself due to an error. We don't want the stack to try to call ops->tx() while we are restarting the hardware. Other IMO valid cases might exist. > Unless i missed something, stop_queue() isn't called outside of the tx > handler in bcm43xx code... You missed something. -- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
