This updates stop_queue(s) kdoc as currently there's a undocumented dependency. Stopping the queue from anywhere else than the ops->tx() callback will result in a hard to debug deadlock and system freeze (on UP). Here's an example stacktrace that has been captured only by special debugging patches to the PPC-decrementer to detect this machine freeze. http://bu3sch.de/misc/freeze1.jpg http://bu3sch.de/misc/freeze2.jpg Signed-off-by: Michael Buesch <mb@xxxxxxxxx> Index: mac80211/include/net/mac80211.h =================================================================== --- mac80211.orig/include/net/mac80211.h 2007-06-01 11:20:32.000000000 +0200 +++ mac80211/include/net/mac80211.h 2007-06-01 11:23:02.000000000 +0200 @@ -967,6 +967,10 @@ void ieee80211_wake_queue(struct ieee802 * @queue: queue number (counted from zero). * * Drivers should use this function instead of netif_stop_queue. + * + * It's currently only safe to call this function from the + * ops->tx() callback. Calls from elsewhere will result in + * hard to debug deadlocks (freezes the system on UP). */ void ieee80211_stop_queue(struct ieee80211_hw *hw, int queue); @@ -983,6 +987,10 @@ void ieee80211_start_queues(struct ieee8 * @hw: pointer as obtained from ieee80211_alloc_hw(). * * Drivers should use this function instead of netif_stop_queue. + * + * It's currently only safe to call this function from the + * ops->tx() callback. Calls from elsewhere will result in + * hard to debug deadlocks (freezes the system on UP). */ void ieee80211_stop_queues(struct ieee80211_hw *hw); -- I'd still prefer someone fixes the issue. I don't understand the code well enough to fix it. -- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
