On Thu, Apr 26, 2007 at 09:53:04AM -0700, Jean Tourrilhes wrote: > On Tue, Apr 24, 2007 at 08:07:41PM +0200, Johannes Berg wrote: > > This patch makes the wext bits in struct net_device depend on > > CONFIG_WIRELESS_EXT. > > > > Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> > > I personally would not do that. Having conditional fields in > "struct net_device" is very bad, it's a sure way to crash on modules > in some cases. If I remember well, Jeff Garzik has been fighting those > over the years. I'm not sure I understand the reasoning here. Without a doubt kernel modules need to be built against the same configuration as the kernels that are loading them. So, conditional component of net_device should not cause crashes. FWIW, there are other conditionally compiled portions of net_device (NETPOLL, NET_POLL_CONTROLLER). I don't see the harm here. John -- John W. Linville linville@xxxxxxxxxxxxx - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
