On Thursday 26 April 2007 18:50:32 Jean Tourrilhes wrote: > On Tue, Apr 24, 2007 at 08:07:39PM +0200, Johannes Berg wrote: > > This patch removes a bunch of inline abuse from wext. Most functions > > that were marked inline are only used once so the compiler will inline > > them anyway, others are used multiple times but there's no requirement > > for them to be inline since they aren't in any fast paths. > > > > Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> > > That's clearly not true of all compilers. All gcc versions > before 4.0 need serious help to inline functions used only once. Our > current minimal requirement for the kernel is gcc 3.2, therefore this > code is still useful. > Note that this is a legitimate use of inline (tell the > compiler to inline the function), not an abuse. By my personal definition _every_ use of inline is abuse, if it's not in an absolute fastpath and applied to a really tiny function. Sure, other people have different opinions on that, but I think with my approach we get smallest code with good speed. In general I try to avoid inline whereever possible. I think this patch is OK and should go in. Often it's even desired to have out of line functions in fastpaths. See spinlocks. -- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
