On Friday 20 April 2007 03:02, Stefano Brivio wrote: > On Thu, 19 Apr 2007 19:23:26 -0400 > > Michael Wu <flamingice@xxxxxxxxxxxx> wrote: > > On Thursday 19 April 2007 18:42, Stefano Brivio wrote: > > > Fix coding style. > > > > Looks mostly good except for.. > > > > > - // ehh? > > > + // XXX: ehh? > > > > Use FIXME if you want to put in a prefix. > > "XXX:" means we don't know if it's a FIXME, a TODO or just correct code. > It's quite used. Unless this is a clear FIXME, I'd keep it. > Sure. But I don't use it in my drivers. Take it out if you don't like FIXME. > > > -} __attribute__ ((packed)); > > > +} __attribute__((packed)); > > > > I prefer the space here. > > Please see CodingStyle. Fair enough. Thanks, -Michael Wu
Attachment:
pgpPP9L3WdkyG.pgp
Description: PGP signature
