Search Linux Wireless

Re: [PATCH] wext: allow wext users without rtnl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Stephen Hemminger <shemminger@xxxxxxxxxxxxxxxxxxxx>
Date: Wed, 18 Apr 2007 14:04:51 -0700

> On Tue, 17 Apr 2007 17:50:10 +0200
> Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> 
> > This patch modifies wext adding a flag that allows drivers to specify that
> > they do not wish their wext calls made under rtnl. The default is to still
> > acquire the rtnl.
> > 
> > Warning: a device reference is held for the new no_locking API,
> > therefore it is not safe to call unregister_netdev on the passed device!
> > 
> > Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> > 
> >
> 
> NACK Conditional locking is bad design.
> Either lock or not, make up your mind and fix the devices.

It is also wrong because all entities in the kernel assume
that network configuration changes all occur under the RTNL
therefore it must be held consistently everywhere.

I don't know what kind of deadlock or other issues are being
worked around here, but you'll have to find another way.
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux