On Monday 09 April 2007 20:59, Larry Finger wrote: > I changed signal to qual and (r)ssi to level. Once these changes were made, > iwconfig gives me the following: > > Link Quality=57/100 Signal level=-37 dBm Noise level=-70 dBm > > The patch is pretty large and touches a lot of files, but if one is to be > able to bisect around it, it has to be a single commit. As the patch > entitled "[PATCH] bcm43xx-mac80211: Fix error in initiallizing max RSSI and > max signal" has been accepted into Michael Buesch's tree, I have assumed > that it is already included. > I would prefer having the bcm43xx-mac80211 fix and the renaming separated into two patches. Also, why wasn't max_rssi changed to max_level? I'm not so sure about doing s/rssi/level/, however. s/rssi/signal/ sounds better to me. (which makes it sound similar to your other patch, except rssi is eliminated because one variable needs to do RSSI/dBm and the other needs to be more general than just another RSSI statistic) The change from "rssi=%d" to "level=%d" looks wrong to me. If any userspace app is parsing that info, that breaks it. Then again, that information is actually redundant since we report IWEVQUAL earlier so it should just be removed. I'll post a patch. Thanks, -Michael Wu
Attachment:
pgpaFYChMAAqI.pgp
Description: PGP signature
