Search Linux Wireless

Re: [PATCH] mac80211: Properly kill tasklets before shutdown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday 23 March 2007 18:32, Jiri Benc wrote:
> On Fri, 23 Mar 2007 18:22:50 +0100, Michael Buesch wrote:
> > kill == (make sure it's not scheduled anymore) && disable
> 
> Are you sure? I cannot find anything in tasklet_kill which disables the
> tasklet.

It doesn't bounce the count, but it waits for the tasklet to finish
and makes sure it's not scheduled anymore.
Why do you want to inc the count? There is no point in that.


disable does: Wait for it to finish running && inc the count

kill does: make sure it's not scheduled, wait for it to finish.

Why disable it? If there's anything scheduling the tasklet while
we have unregistered we _want_ it to crash, as that's a real bug
in the first place. (And I don't think it's possible to
schedule it after unregister).

-- 
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux