On Friday 23 March 2007 18:17, Jiri Benc wrote: > On Tue, 6 Mar 2007 19:01:59 +0100, Michael Buesch wrote: > > We need to do tasklet_kill() on any tasklet on unregister > > to make sure the tasklet is not running _and_ scheduled anymore. > > (tasklet_disable() only ensures it's not running anymore). > > > > This fixes the tasklet related crash that was reported some time ago. > > > > Signed-off-by: Michael Buesch <mb@xxxxxxxxx> > > > > Index: bu3sch-wireless-dev/net/mac80211/ieee80211.c > > =================================================================== > > --- bu3sch-wireless-dev.orig/net/mac80211/ieee80211.c 2007-03-06 15:55:53.000000000 +0100 > > +++ bu3sch-wireless-dev/net/mac80211/ieee80211.c 2007-03-06 15:58:10.000000000 +0100 > > @@ -4761,8 +4761,8 @@ > > struct ieee80211_sub_if_data *sdata, *tmp; > > int i; > > > > - tasklet_disable(&local->tasklet); > > I think this tasklet_disable should not be removed. Why?... > > - /* TODO: skb_queue should be empty here, no need to do anything? */ > > + tasklet_kill(&local->tx_pending_tasklet); > > + tasklet_kill(&local->tasklet); ...We kill it here. kill == (make sure it's not scheduled anymore) && disable -- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
