On Wednesday 21 March 2007 01:22, John W. Linville wrote: > Comments? Patches? I'll try to come up with a patch later today to move the eeprom_93cx6 module to the correct location (drivers/misc) and fix the help text in KConfig. Ivo > ----- Forwarded message from Randy Dunlap <randy.dunlap@xxxxxxxxxx> ----- > > > Date: Tue, 20 Mar 2007 16:49:23 -0700 > > From: Randy Dunlap <randy.dunlap@xxxxxxxxxx> > > To: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > Cc: linux-kernel@xxxxxxxxxxxxxxx > > Subject: Re: 2.6.21-rc4-mm1 > > In-Reply-To: <20070319205623.299d0378.akpm@xxxxxxxxxxxxxxxxxxxx> > > Organization: Oracle Linux Eng. > > X-Mailer: Sylpheed 2.3.1 (GTK+ 2.8.10; x86_64-unknown-linux-gnu) > > X-Whitelist: TRUE > > X-Whitelist: TRUE > > X-Brightmail-Tracker: AAAAAQAAAAI= > > Precedence: bulk > > X-Mailing-List: linux-kernel@xxxxxxxxxxxxxxx > > X-Spam-Status: No, score=-2.6 required=3.0 tests=AWL,BAYES_00,SPF_HELO_PASS, > > SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.1.3-gr0 > > X-Spam-Checker-Version: SpamAssassin 3.1.3-gr0 (2006-06-01) on > > ra.tuxdriver.com > > > > On Mon, 19 Mar 2007 20:56:23 -0800 Andrew Morton wrote: > > > > > > > > Temporarily at > > > > > > http://userweb.kernel.org/~akpm/2.6.21-rc4-mm1/ > > > > > > Will appear later at > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc4/2.6.21-rc4-mm1/ > > > > > > I think that this: > > > > config EEPROM_93CX6 > > tristate "EEPROM 93CX6 support" > > ---help--- > > This is a driver for the EEPROM chipsets 93c46 and 93c66. > > The driver supports both read as well as write commands. > > > > should not be in lib/Kconfig. lib/ is not for drivers. > > or (simpler) s/driver/library/ > > but I think I'd rather see it in drivers/misc/. > > > > > > and the help text needs to be indented 2 more spaces... > > > > --- > > ~Randy > > boilerplate: > > *** Remember to use Documentation/SubmitChecklist when testing your code *** > > - > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > ----- End forwarded message ----- > - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
