Search Linux Wireless

Re: [PATCH 2/2] mac80211: Monitor mode radiotap-based packet injection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Saturday 17 March 2007 06:58, andy@xxxxxxxxxxx wrote:
> diff --git a/net/mac80211/ieee80211.c b/net/mac80211/ieee80211.c
> index fb33b90..3873262 100644
> --- a/net/mac80211/ieee80211.c
> +++ b/net/mac80211/ieee80211.c
> @@ -35,6 +35,7 @@
>  #include "ieee80211_led.h"
>  #include "ieee80211_cfg.h"
>  #include "ieee80211_sysfs.h"
> +#include <net/ieee80211_radiotap.h>
>
Already included by my patch.

> +	int tap_index = 0;
> +	u8 *tap_arg = skb->data + sizeof(struct ieee80211_radiotap_header);
> +	u32 *curr_arg_bitmap = &rthdr->it_present;
> +	u32 arg_bitmap=le32_to_cpu(*curr_arg_bitmap);
Space before and after the =. 

> +
> +	if(rthdr->it_version) return TXRX_DROP; /* version byte used as magic */
Space after the if.

> +
> +		/* sanity check for skb length and radiotap length field */
Keep comments indented the same as everything else.

> +	if (skb->len < (le16_to_cpu(rthdr->it_len) +
> +		sizeof(struct ieee80211_hdr)))
Using some spaces to align the start of the second line with the parenthesis 
often looks better.

> +		/* process and remove the injection radiotap header */
> +
> +	if(control->flags & IEEE80211_TXCTL_INJECTED_PACKET) {
dev points to the virtual interface that the frame originally came in on. You 
can get sdata from that and figure out if the interface was a monitor 
interface.

Thanks,
-Michael Wu

Attachment: pgpGHpwkODLxQ.pgp
Description: PGP signature


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux