Search Linux Wireless

Re: [PATCH 2/2] mac80211: Monitor mode radiotap-based packet injection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Michael Buesch wrote:
On Saturday 17 March 2007 15:58, Andy Green wrote:
Michael Buesch wrote:

+#define IEEE80211_TXCTL_INJECTED_PACKET (1<<10) /* tx into monitor IF */
What is a driver supposed to do on this flag? More documentation, please.
Hi Michael -

The driver doesn't have to do anything with that flag... it's a private mac80211-internal flag to get the attribute that the packet was injected

If there's a simpler way I'm happy to use it.

Ok, no. I'm fine with this. But please mark it as mac80211-internal
flag, so driver authors don't waste time on thinking about wtf this is. ;)
Either by documenting it in a comment or by doing a special define
(two underscores or something). Or both.

Both sounds like a good idea, thanks: I will wait a bit for any more comments and then add this to a try #3. I noticed Michael Wu set his flag to 1<<20 and I guess he had this in mind, so I will change mine to 1<<21 to further distance it from the other flags in bits and in meaning.

-Andy



-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux