On Wed, 2007-03-07 at 22:24 +0000, Christoph Hellwig wrote: > On Wed, Mar 07, 2007 at 03:16:38PM -0300, Marcelo Tosatti wrote: > > > - please get rid of the ENTER/LEAVE macros > > > > These are useful for debugging. We have removed most of the useless ones > > already. > > We've refused this on a lot of drivers. If you really need this kind > of debugging talk to acme to use a variant of ostra for this. > > > > - please get rid of all your private ioctls and iwpriv stuff > > > (should I add !!!! here) > > > > Rationale being? There are a bunch of device private knobs, and iwpriv > > is the interface for such configuration. (????) > > If you read netdev we're very very unhappy about device specific knobs, > as they are really painful to support. You should also look at the > cfg80211 threads on why ioctls are really bad for moving to a knew > non-wext, non-ioctl config mechanism. And for why iwpriv is particularly > bad look about the posts about the wext compat issues. We are unhappy with specific knobs _if_and_only_if_ they duplicate functionality that's currently available. That means, for example, the prism2 WPA ioctls, because WE-19 has equivalent functionality. Other examples include many of the madwifi ioctls like auth_mode for which there are WEXT calls. Others include the ones for creating virtual STAs that are now subsumed by mac80211. For stuff that's seriously not common among drivers, there's nothing else that drivers can do but provide private ioctls. Dan - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
