On Wed, Mar 07, 2007 at 03:16:38PM -0300, Marcelo Tosatti wrote: > > - please get rid of the ENTER/LEAVE macros > > These are useful for debugging. We have removed most of the useless ones > already. We've refused this on a lot of drivers. If you really need this kind of debugging talk to acme to use a variant of ostra for this. > > - please get rid of all your private ioctls and iwpriv stuff > > (should I add !!!! here) > > Rationale being? There are a bunch of device private knobs, and iwpriv > is the interface for such configuration. (????) If you read netdev we're very very unhappy about device specific knobs, as they are really painful to support. You should also look at the cfg80211 threads on why ioctls are really bad for moving to a knew non-wext, non-ioctl config mechanism. And for why iwpriv is particularly bad look about the posts about the wext compat issues. - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
