Hi, On 8/22/23 16:18, Andy Shevchenko wrote: > While it's pretty much theoretical to be otherwise, make sure > that P2SB is selected only for X86. This is idiomatic dependency > which is used by all others who select it. Use it for Simatic > as well. Hmm, this already depends on SIEMENS_SIMATIC_IPC which itself depends on X86, so as you already say this is not really necessary... > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Note this depends on / applies on top of 2 other "config SIEMENS_SIMATIC_IPC_WDT" patches which are currently pending in pdx86/for-next: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next so this should probably be merged after 6.6-rc1 once these other changes have been merged. Regards, Hans > --- > drivers/watchdog/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index a75f6acb986b..751458959411 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -1685,7 +1685,7 @@ config SIEMENS_SIMATIC_IPC_WDT > depends on SIEMENS_SIMATIC_IPC && PCI > default y > select WATCHDOG_CORE > - select P2SB > + select P2SB if X86 > help > This driver adds support for several watchdogs found in Industrial > PCs from Siemens.
